Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation warning #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

srghma
Copy link
Member

@srghma srghma commented Oct 14, 2024

Description of the change
as per

garyb/purescript-codec-json#8 (comment)


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

Copy link
Member

@jamesdbrock jamesdbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I think we should merge? @garyb ?

@garyb
Copy link
Member

garyb commented Oct 23, 2024

I was a little reluctant to flip things over to purescript-json as it's not had heavy usage yet, but realistically it's mostly the same as argonaut-core anyway, so yeah I think pointing people there is fine.

The main thing would be that there is no traversals or codecs equivalent for it. I don't think traversals got much use, codecs definitely does, but I have no interest in creating/maintaining a typeclass codecs library equivalent. I know some people will not love that, since it's undoubtedly more convenient than the value codecs approach I prefer (until it isn't 😄), but I suppose there's yoga-json for something more along the lines of that approach (mostly, it's more intended for convenient usage of JSON equivalent PS types so still might need a layer of serialization types).

@jamesdbrock
Copy link
Member

This looks good to me, I think we should merge?

I retract this. I'm in no hurry to deprecate this package. I have no opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants